Skip to content

fixes issue #662 (enables Pointer Lock Web API) #210875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 30, 2025

Conversation

whistlegraph
Copy link
Contributor

@whistlegraph whistlegraph commented Apr 22, 2024

This change fixes microsoft/vscode-extension-samples#662
fixes #221593

By explicitly allowing the pointerLock permission in the root document of the VS Code window.

Testing

  • You can test this change using the aesthetic-computer.aesthetic-computer-code extension in the Marketplace.
  • Open the Aesthetic Computer pane from the Activity Bar.
  • Enter fps and press [Enter].
  • Press [Escape] to end the Pointer Lock.

@dbaeumer dbaeumer assigned bpasero and unassigned dbaeumer Apr 23, 2024
@bpasero bpasero assigned mjbvz and unassigned bpasero Apr 23, 2024
@mjbvz mjbvz added this to the July 2024 milestone Jul 12, 2024
@mjbvz mjbvz modified the milestones: July 2024, August 2024 Jul 24, 2024
@mjbvz mjbvz modified the milestones: August 2024, September 2024 Aug 28, 2024
@mjbvz mjbvz modified the milestones: September 2024, October 2024 Sep 26, 2024
@mjbvz mjbvz modified the milestones: October 2024, November 2024 Oct 21, 2024
@mjbvz mjbvz modified the milestones: November 2024, January 2025 Dec 5, 2024
@mjbvz mjbvz enabled auto-merge January 13, 2025 22:18
@mjbvz mjbvz modified the milestones: January 2025, February 2025 Jan 28, 2025
@aeschli aeschli added the postponed-during-endgame Endgame champ removed the planed milestone label Feb 27, 2025
@aeschli aeschli modified the milestones: February 2025, Backlog Feb 27, 2025
@mjbvz mjbvz modified the milestones: Backlog, April 2025 Apr 30, 2025
@mjbvz mjbvz merged commit 9244832 into microsoft:main Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
postponed-during-endgame Endgame champ removed the planed milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pointer lock doesn't work with webview panel in extension Please add a minimal sample for creating an LSP client.
6 participants